From: Jocelyn Falempe Date: Fri, 19 Jul 2024 15:24:13 +0000 (+0200) Subject: mtd: mtdoops: Fix kmsgdump parameter renaming. X-Git-Tag: v6.12-rc1~126^2~24^2~76 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1f7ce4316d8c8ca8fdf5e477fee91012420b1fa3;p=thirdparty%2Fkernel%2Flinux.git mtd: mtdoops: Fix kmsgdump parameter renaming. When the kmsg_dumper callback parameter changed, the reason variable in mtdoops_do_dump() was not updated accordingly. This breaks the build with mtdoops. Fixes: e1a261ba599e ("printk: Add a short description string to kmsg_dump()") Suggested-by: Knop Ryszard Signed-off-by: Jocelyn Falempe Acked-by: Richard Weinberger Link: https://patchwork.freedesktop.org/patch/msgid/20240719152542.1554440-1-jfalempe@redhat.com --- diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c index 86d49db9196d8..7bf3777e1f137 100644 --- a/drivers/mtd/mtdoops.c +++ b/drivers/mtd/mtdoops.c @@ -305,7 +305,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper, struct kmsg_dump_iter iter; /* Only dump oopses if dump_oops is set */ - if (reason == KMSG_DUMP_OOPS && !dump_oops) + if (detail->reason == KMSG_DUMP_OOPS && !dump_oops) return; kmsg_dump_rewind(&iter); @@ -317,7 +317,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper, record_size - sizeof(struct mtdoops_hdr), NULL); clear_bit(0, &cxt->oops_buf_busy); - if (reason != KMSG_DUMP_OOPS) { + if (detail->reason != KMSG_DUMP_OOPS) { /* Panics must be written immediately */ mtdoops_write(cxt, 1); } else {