From: Glen Choo Date: Thu, 31 Mar 2022 22:41:17 +0000 (-0700) Subject: branch: rework comments for future developers X-Git-Tag: v2.36.0-rc0~9^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1f888282e2914283890f61000a7589d32b4132bc;p=thirdparty%2Fgit.git branch: rework comments for future developers For two cases in which we do not explicitly pass --track= option down to the submodule--helper subprocess, we have comments that say "we do not have to pass --track", but in fact we not just do not have to, but it would be incorrect to pass any --track option to the subprocess (instead, the correct behaviour is to let the subprocess figure out what is the appropriate tracking mode to use). Signed-off-by: Glen Choo Signed-off-by: Junio C Hamano --- diff --git a/branch.c b/branch.c index ed6f993aa6..8ee9f43539 100644 --- a/branch.c +++ b/branch.c @@ -549,9 +549,9 @@ static int submodule_create_branch(struct repository *r, strvec_push(&child.args, "--track=inherit"); break; case BRANCH_TRACK_UNSPECIFIED: - /* Default for "git checkout". No need to pass --track. */ + /* Default for "git checkout". Do not pass --track. */ case BRANCH_TRACK_REMOTE: - /* Default for "git branch". No need to pass --track. */ + /* Default for "git branch". Do not pass --track. */ break; }