From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 7 Jan 2016 09:36:06 +0000 (+0300)
Subject: iommu/amd: Remove an unneeded condition
X-Git-Tag: v4.5-rc1~61^2^7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fb260bc003d7c6196fc0ee3a169a2f6495d17fe;p=thirdparty%2Fkernel%2Flinux.git

iommu/amd: Remove an unneeded condition

get_device_id() returns an unsigned short device id.  It never fails and
it never returns a negative so we can remove this condition.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 6f6502d9fd673..539b0dea8034b 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3857,11 +3857,9 @@ static struct irq_domain *get_irq_domain(struct irq_alloc_info *info)
 	case X86_IRQ_ALLOC_TYPE_MSI:
 	case X86_IRQ_ALLOC_TYPE_MSIX:
 		devid = get_device_id(&info->msi_dev->dev);
-		if (devid >= 0) {
-			iommu = amd_iommu_rlookup_table[devid];
-			if (iommu)
-				return iommu->msi_domain;
-		}
+		iommu = amd_iommu_rlookup_table[devid];
+		if (iommu)
+			return iommu->msi_domain;
 		break;
 	default:
 		break;