From: Richard Henderson <rth@redhat.com>
Date: Thu, 21 Nov 2002 18:54:24 +0000 (+0000)
Subject:         * elflink.h (elf_link_add_object_symbols): Don't overwrite the
X-Git-Tag: binutils-2_13_2~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fb4735a7639df01bf2ba73d2a0982aa49c77af0;p=thirdparty%2Fbinutils-gdb.git

    * elflink.h (elf_link_add_object_symbols): Don't overwrite the
        arch's st_other bits when merging visibilities.
        (elf_link_output_extsym): Tidy clearing of visibility field.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 21a4ef9c7c8..2a546491dd3 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2002-11-21  Richard Henderson  <rth@redhat.com>
+
+        * elflink.h (elf_link_add_object_symbols): Don't overwrite the
+        arch's st_other bits when merging visibilities.
+        (elf_link_output_extsym): Tidy clearing of visibility field.
+
 2002-11-14  David O'Brien  <obrien@FreeBSD.org>
 
 	Merge from mainline:
diff --git a/bfd/elflink.h b/bfd/elflink.h
index 079917ef75d..6887e506ab7 100644
--- a/bfd/elflink.h
+++ b/bfd/elflink.h
@@ -1938,19 +1938,17 @@ elf_link_add_object_symbols (abfd, info)
 	     might be needed here.  */
 	  if (isym->st_other != 0)
 	    {
+	      unsigned char hvis, symvis, other;
+
+	      /* Take the balance of OTHER from the definition.  */
+	      other = (definition ? isym->st_other : h->other);
+	      other &= ~ ELF_ST_VISIBILITY (-1);
+
 	      /* Combine visibilities, using the most constraining one.  */
-	      unsigned char hvis   = ELF_ST_VISIBILITY (h->other);
-	      unsigned char symvis = ELF_ST_VISIBILITY (isym->st_other);
-
-	      if (symvis && (hvis > symvis || hvis == 0))
-		h->other = isym->st_other;
-
-	      /* If neither has visibility, use the st_other of the
-		 definition.  This is an arbitrary choice, since the
-		 other bits have no general meaning.  */
-	      if (!symvis && !hvis
-		  && (definition || h->other == 0))
-		h->other = isym->st_other;
+	      hvis   = ELF_ST_VISIBILITY (h->other);
+	      symvis = ELF_ST_VISIBILITY (isym->st_other);
+
+	      h->other = other | (hvis > symvis ? hvis : symvis);
 	    }
 
 	  /* Set a flag in the hash table entry indicating the type of
@@ -6352,11 +6350,10 @@ elf_link_output_extsym (h, data)
       sym.st_info = ELF_ST_INFO (bindtype, ELF_ST_TYPE (sym.st_info));
     }
 
-  /* If a symbol is not defined locally, we clear the visibility
-     field.  */
+  /* If a symbol is not defined locally, we clear the visibility field.  */
   if (! finfo->info->relocateable
       && (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) == 0)
-    sym.st_other ^= ELF_ST_VISIBILITY (sym.st_other);
+    sym.st_other &= ~ ELF_ST_VISIBILITY (-1);
 
   /* If this symbol should be put in the .dynsym section, then put it
      there now.  We already know the symbol index.  We also fill in