From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 30 Jul 2025 07:07:49 +0000 (+0200)
Subject: Be more careful when looking into the domains table.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fc030ee2cda3658025b787ca12327c81b161d87;p=thirdparty%2Fpdns.git

Be more careful when looking into the domains table.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index d1e5e162c..dc0af2818 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1687,7 +1687,9 @@ bool LMDBBackend::deleteDomain(const ZoneName& domain)
     auto txn = d_tdomains->getROTransaction();
 
     DomainInfo di;
-    idvec.push_back(txn.get<0>(domain, di));
+    if (auto id = txn.get<0>(domain, di); id != 0) {
+      idvec.push_back(id);
+    }
   }
   else {
     // this transaction used to be RO.
@@ -2036,6 +2038,9 @@ int LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<voi
   DomainInfo di;
 
   auto id = txn.get<0>(domain, di);
+  if (id == 0) {
+    return false;
+  }
   func(di);
   txn.put(di, id);