From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 2 Mar 2015 09:09:49 +0000 (+0100)
Subject: storage: sheepdog: Avoid skipping variable initialization
X-Git-Tag: v1.2.14-rc1~307
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fcb9351d7e5affce2961d661ee08abde6853675;p=thirdparty%2Flibvirt.git

storage: sheepdog: Avoid skipping variable initialization

Commit 155ca616eb231181f6978efc9e3a1eb0eb60af8a added a error message
that skips initialization of the 'cmd' variable. Fortunately it was not
released.
---

diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c
index f389d9bc53..af15c3b1e2 100644
--- a/src/storage/storage_backend_sheepdog.c
+++ b/src/storage/storage_backend_sheepdog.c
@@ -263,6 +263,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
                                   unsigned int flags)
 {
     int ret = -1;
+    virCommandPtr cmd = NULL;
 
     virCheckFlags(0, -1);
 
@@ -272,7 +273,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
         goto cleanup;
     }
 
-    virCommandPtr cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
+    cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);
     virCommandAddArgFormat(cmd, "%llu", vol->target.capacity);
     virStorageBackendSheepdogAddHostArg(cmd, pool);
     if (virCommandRun(cmd, NULL) < 0)