From: Timo Sirainen Date: Thu, 9 Apr 2020 20:08:39 +0000 (+0300) Subject: login-proxy: Remove dead code checking if client is destroyed X-Git-Tag: 2.3.11.2~216 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fd54824fa805545bfb15a1e334f7330a16c8c44;p=thirdparty%2Fdovecot%2Fcore.git login-proxy: Remove dead code checking if client is destroyed The beginning of the function already assert-crashes if client is destroyed and nothing in the code path can destroy the client. --- diff --git a/src/login-common/client-common-auth.c b/src/login-common/client-common-auth.c index 15f1dcccfc..75deabda5c 100644 --- a/src/login-common/client-common-auth.c +++ b/src/login-common/client-common-auth.c @@ -422,11 +422,6 @@ static int proxy_start(struct client *client, i_assert(client->refcount > 1); - if (client->destroyed) { - /* connection_queue_add() decided that we were the oldest - connection and killed us. */ - return -1; - } if (login_proxy_is_ourself(client, reply->host, reply->port, reply->destuser)) { e_error(client->event, "Proxying loops to itself");