From: René Scharfe <l.s.r@web.de>
Date: Sun, 25 Aug 2019 17:44:10 +0000 (+0200)
Subject: trace2: use warning() directly in tr2_dst_malformed_warning()
X-Git-Tag: v2.24.0-rc0~123^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1fd881d4046fb42f77ff9031ef07b7a18028ece0;p=thirdparty%2Fgit.git

trace2: use warning() directly in tr2_dst_malformed_warning()

Let warning() format the message instead of using an intermediate strbuf
for that.  This is shorter, easier to read and avoids an allocation.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
index 7d96f33420..6c425f17f3 100644
--- a/trace2/tr2_dst.c
+++ b/trace2/tr2_dst.c
@@ -166,13 +166,8 @@ connected:
 static void tr2_dst_malformed_warning(struct tr2_dst *dst,
 				      const char *tgt_value)
 {
-	struct strbuf buf = STRBUF_INIT;
-
-	strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
-		    tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
-	warning("%s", buf.buf);
-
-	strbuf_release(&buf);
+	warning("trace2: unknown value for '%s': '%s'",
+		tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
 }
 
 int tr2_dst_get_trace_fd(struct tr2_dst *dst)