From: Sean Bright <sean.bright@gmail.com>
Date: Tue, 23 Jul 2019 17:58:31 +0000 (-0400)
Subject: res_config_sqlite3: Only join threads that we started
X-Git-Tag: 13.29.0-rc1~32^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=202fdc88dd22bd7daa10d2f3aa6626ca32203d25;p=thirdparty%2Fasterisk.git

res_config_sqlite3: Only join threads that we started

ASTERISK-28477 #close
Reported by: Dennis

ASTERISK-28478 #close
Reported by: Dennis

Change-Id: I77347ad46a86dc5b35ed68270cee56acefb4f475
---

diff --git a/res/res_config_sqlite3.c b/res/res_config_sqlite3.c
index 6148d5d875..d321cb7c5d 100644
--- a/res/res_config_sqlite3.c
+++ b/res/res_config_sqlite3.c
@@ -104,6 +104,7 @@ struct realtime_sqlite3_db {
 	unsigned int debug:1;
 	unsigned int exiting:1;
 	unsigned int wakeup:1;
+	unsigned int has_batch_thread:1;
 	unsigned int batch;
 };
 
@@ -368,13 +369,14 @@ void db_start_batch(struct realtime_sqlite3_db *db)
 	if (db->batch) {
 		ast_cond_init(&db->cond, NULL);
 		ao2_ref(db, +1);
-		ast_pthread_create_background(&db->syncthread, NULL, db_sync_thread, db);
+		db->has_batch_thread = !ast_pthread_create_background(&db->syncthread, NULL, db_sync_thread, db);
 	}
 }
 
 void db_stop_batch(struct realtime_sqlite3_db *db)
 {
-	if (db->batch) {
+	if (db->has_batch_thread) {
+		db->has_batch_thread = 0;
 		db->exiting = 1;
 		db_sync(db);
 		pthread_join(db->syncthread, NULL);