From: Willy Tarreau <w@1wt.eu>
Date: Mon, 17 Mar 2014 17:04:27 +0000 (+0100)
Subject: CLEANUP: acl: remove obsolete test in parse_acl_expr()
X-Git-Tag: v1.5-dev23~134
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2049092f26efd83508b7d775f948e04ec0e1c532;p=thirdparty%2Fhaproxy.git

CLEANUP: acl: remove obsolete test in parse_acl_expr()

The ACL keyword returned by find_acl_kw() is checked for having a
valid ->parse() function. This dates back 2007 when ACLs were reworked
in order to differenciate old and new keywords. This check is
inappropriate and confusing since all keywords have a parser now.
---

diff --git a/src/acl.c b/src/acl.c
index b04c9dfa99..abfd04cc2a 100644
--- a/src/acl.c
+++ b/src/acl.c
@@ -156,7 +156,7 @@ struct acl_expr *parse_acl_expr(const char **args, char **err, struct arg_list *
 	al->conv = NULL;
 
 	aclkw = find_acl_kw(args[0]);
-	if (aclkw && aclkw->parse) {
+	if (aclkw) {
 		/* OK we have a real ACL keyword */
 
 		/* build new sample expression for this ACL */