From: Peng Li <lipeng321@huawei.com>
Date: Wed, 16 Jun 2021 07:23:30 +0000 (+0800)
Subject: net: cosa: replace comparison to NULL with "!chan->rx_skb"
X-Git-Tag: v5.14-rc1~119^2~155^2~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2076b3e61a323e38256be44289aa32ae12ecf79a;p=thirdparty%2Fkernel%2Flinux.git

net: cosa: replace comparison to NULL with "!chan->rx_skb"

According to the chackpatch.pl, comparison to NULL could
be written "!chan->rx_skb".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index c051c6120e309..7b57233aeec9b 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -719,7 +719,7 @@ static char *cosa_net_setup_rx(struct channel_data *chan, int size)
 	 */
 	kfree_skb(chan->rx_skb);
 	chan->rx_skb = dev_alloc_skb(size);
-	if (chan->rx_skb == NULL) {
+	if (!chan->rx_skb) {
 		pr_notice("%s: Memory squeeze, dropping packet\n", chan->name);
 		chan->netdev->stats.rx_dropped++;
 		return NULL;
@@ -783,7 +783,7 @@ static ssize_t cosa_read(struct file *file,
 		return -ERESTARTSYS;
 	
 	chan->rxdata = kmalloc(COSA_MTU, GFP_DMA|GFP_KERNEL);
-	if (chan->rxdata == NULL) {
+	if (!chan->rxdata) {
 		mutex_unlock(&chan->rlock);
 		return -ENOMEM;
 	}
@@ -861,7 +861,7 @@ static ssize_t cosa_write(struct file *file,
 	
 	/* Allocate the buffer */
 	kbuf = kmalloc(count, GFP_KERNEL|GFP_DMA);
-	if (kbuf == NULL) {
+	if (!kbuf) {
 		up(&chan->wsem);
 		return -ENOMEM;
 	}