From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Wed, 17 May 2017 13:21:54 +0000 (+0300)
Subject: lib-index: Add missing error logging for mail_index_view_sync_begin()
X-Git-Tag: 2.3.0.rc1~1587
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=20a10690f6dd922b36f72f995c95b96face85971;p=thirdparty%2Fdovecot%2Fcore.git

lib-index: Add missing error logging for mail_index_view_sync_begin()
---

diff --git a/src/lib-index/mail-index-view-sync.c b/src/lib-index/mail-index-view-sync.c
index 8b027fee56..c458798a09 100644
--- a/src/lib-index/mail-index-view-sync.c
+++ b/src/lib-index/mail-index-view-sync.c
@@ -74,8 +74,12 @@ view_sync_set_log_view_range(struct mail_index_view *view, bool sync_expunges,
 						    start_seq, start_offset,
 						    end_seq, end_offset,
 						    reset_r, &reason);
-		if (ret <= 0)
+		if (ret <= 0) {
+			mail_index_set_error(view->index,
+				"Failed to map view for %s: %s",
+				view->index->filepath, reason);
 			return ret;
+		}
 
 		if (!*reset_r || sync_expunges)
 			break;
@@ -508,12 +512,10 @@ static int mail_index_view_sync_init_fix(struct mail_index_view_sync_ctx *ctx)
 
 	ret = mail_transaction_log_view_set(view->log_view, seq, offset,
 					    seq, offset, &reset, &reason);
-	if (ret < 0)
-		return -1;
-	if (ret == 0) {
+	if (ret <= 0) {
 		mail_index_set_error(view->index, "Failed to fix view for %s: %s",
 				     view->index->filepath, reason);
-		return 0;
+		return ret;
 	}
 	view->inconsistent = FALSE;
 	return 0;