From: Junio C Hamano Date: Tue, 18 Feb 2020 21:21:46 +0000 (-0800) Subject: rev-list --count: comment on the use of count_right++ X-Git-Tag: v2.26.0-rc0~26^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=20a5fd881a98cfe153fa5a81754994c7046a6e41;p=thirdparty%2Fgit.git rev-list --count: comment on the use of count_right++ Signed-off-by: Junio C Hamano --- diff --git a/builtin/rev-list.c b/builtin/rev-list.c index 35e14ad2ed..f520111eda 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -262,6 +262,13 @@ static void show_object(struct object *obj, const char *name, void *cb_data) return; if (revs->count) { + /* + * The object count is always accumulated in the .count_right + * field for traversal that is not a left-right traversal, + * and cmd_rev_list() made sure that a .count request that + * wants to count non-commit objects, which is handled by + * the show_object() callback, does not ask for .left_right. + */ revs->count_right++; return; }