From: Cyril Bonté <cyril.bonte@free.fr>
Date: Thu, 10 May 2012 17:42:52 +0000 (+0200)
Subject: BUG/MINOR: stats admin: "Unexpected result" was displayed unconditionally
X-Git-Tag: v1.5-dev10~19
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=20a804ac6d876cc1b3307fac0b0d67499bee831a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stats admin: "Unexpected result" was displayed unconditionally

I introduced a regression in commit 19979e176e while reworking the admin
actions results.
"Unexpected result" was displayed even if the action was applied due to a
misplaced initialization. This small patch should fix it.

Note: no need to backport.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index 3db7de1fac..39a1fd6a13 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -7150,13 +7150,13 @@ int stats_check_uri(struct stream_interface *si, struct http_txn *txn, struct pr
 		if (memcmp(h, ";st=", 4) == 0) {
 			int i;
 			h += 4;
+			si->applet.ctx.stats.st_code = STAT_STATUS_UNKN;
 			for (i = STAT_STATUS_INIT + 1; i < STAT_STATUS_SIZE; i++) {
 				if (strncmp(stat_status_codes[i], h, 4) == 0) {
 					si->applet.ctx.stats.st_code = i;
 					break;
 				}
 			}
-			si->applet.ctx.stats.st_code = STAT_STATUS_UNKN;
 			break;
 		}
 		h++;