From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 5 Aug 2020 09:52:07 +0000 (+0300)
Subject: cifs: Fix an error pointer dereference in cifs_mount()
X-Git-Tag: v5.9-rc1~12^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=20b135e48cdda7a7dfccef7286def66e5c9686c3;p=thirdparty%2Fkernel%2Flinux.git

cifs: Fix an error pointer dereference in cifs_mount()

The error handling calls kfree(full_path) so we can't let it be a NULL
pointer.  There used to be a NULL assignment here but we accidentally
deleted it.  Add it back.

Fixes: 7efd08158261 ("cifs: document and cleanup dfs mount")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 7e3e5e2098eb2..2fe6b1ab75c3f 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4886,6 +4886,7 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb_vol *vol)
 		full_path = build_unc_path_to_root(vol, cifs_sb, !!count);
 		if (IS_ERR(full_path)) {
 			rc = PTR_ERR(full_path);
+			full_path = NULL;
 			break;
 		}
 		/* Chase referral */