From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 2 Feb 2015 21:08:29 +0000 (+0100)
Subject: ata: Delete unnecessary checks before the function call "pci_dev_put"
X-Git-Tag: v4.0-rc1~148^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=214f1aff3f33bc86cc85ece4080d9518af688fb1;p=thirdparty%2Fkernel%2Fstable.git

ata: Delete unnecessary checks before the function call "pci_dev_put"

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
---

diff --git a/drivers/ata/pata_cs5530.c b/drivers/ata/pata_cs5530.c
index 48ae4b4344745..f9ca72e937ee1 100644
--- a/drivers/ata/pata_cs5530.c
+++ b/drivers/ata/pata_cs5530.c
@@ -276,10 +276,8 @@ static int cs5530_init_chip(void)
 	pci_dev_put(cs5530_0);
 	return 0;
 fail_put:
-	if (master_0)
-		pci_dev_put(master_0);
-	if (cs5530_0)
-		pci_dev_put(cs5530_0);
+	pci_dev_put(master_0);
+	pci_dev_put(cs5530_0);
 	return -ENODEV;
 }