From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 1 Jun 2013 10:01:13 +0000 (-0600)
Subject: Fix typo in rev.12859
X-Git-Tag: SQUID_3_4_0_1~86
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2154a209d636b7f228f546a69142212f28d4788f;p=thirdparty%2Fsquid.git

Fix typo in rev.12859

cbdataReference() is a macro with a design which means it requires usage
in the form of an assignment. ie a = cbdataReference(B); , or as a
parameter in equivalent to a variable.

Not using it in either of those manners results in syntax errors about a
',' from any strict compiler, and many older versions of GCC.
---

diff --git a/src/acl/Checklist.cc b/src/acl/Checklist.cc
index 6ce65b93c9..9d4ccfb201 100644
--- a/src/acl/Checklist.cc
+++ b/src/acl/Checklist.cc
@@ -291,11 +291,10 @@ ACLChecklist::fastCheck(const Acl::Tree * list)
     // tell whether this Checklist is used by some other concurent call, which
     // is not supported.
     assert(!accessList);
-    accessList = list;
+    accessList = cbdataReference(list);
 
     // assume DENY/ALLOW on mis/matches due to action-free accessList
     // matchAndFinish() takes care of the ALLOW case
-    cbdataReference(accessList); // required for cbdataReferenceValid()
     if (accessList && cbdataReferenceValid(accessList))
         matchAndFinish(); // calls markFinished() on success
     if (!finished())