From: Cornelia Huck Date: Thu, 2 May 2019 15:46:51 +0000 (+0200) Subject: s390/ipl: cast to SCSIDevice directly X-Git-Tag: v4.1.0-rc0~98^2~13 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=216bdd274ae6111102d5f35a4fc6a580e4bc913d;p=thirdparty%2Fqemu.git s390/ipl: cast to SCSIDevice directly Coverity notes that the result of object_dynamic_cast() to SCSIDevice is not checked in s390_gen_initial_iplp(); as we know that we always have a SCSIDevice in that branch, we can instead cast via SCSI_DEVICE directly. Coverity: CID 1401098 Fixes: 44445d8668f4 ("s390 vfio-ccw: Add bootindex property and IPLB data") Message-Id: <20190502155516.12415-1-cohuck@redhat.com> Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index d0cc06a05fd..b93750c14ea 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -374,8 +374,7 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl) if (ccw_dev) { switch (devtype) { case CCW_DEVTYPE_SCSI: - sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st), - TYPE_SCSI_DEVICE); + sd = SCSI_DEVICE(dev_st); ipl->iplb.len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN); ipl->iplb.blk0_len = cpu_to_be32(S390_IPLB_MIN_QEMU_SCSI_LEN - S390_IPLB_HEADER_LEN);