From: Pauli <ppzgs1@gmail.com>
Date: Sun, 21 Mar 2021 23:05:40 +0000 (+1000)
Subject: ec_keymgmt: fix coverity 1474427: resource leak
X-Git-Tag: openssl-3.0.0-alpha14~155
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=218e1263c4f2ac014859bcd6b72d0e66a3f75d95;p=thirdparty%2Fopenssl.git

ec_keymgmt: fix coverity 1474427: resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14637)
---

diff --git a/providers/implementations/keymgmt/ec_kmgmt.c b/providers/implementations/keymgmt/ec_kmgmt.c
index 2ba21dfb391..b8aa518a081 100644
--- a/providers/implementations/keymgmt/ec_kmgmt.c
+++ b/providers/implementations/keymgmt/ec_kmgmt.c
@@ -847,13 +847,13 @@ int sm2_validate(const void *keydata, int selection, int checktype)
     if (!ossl_prov_is_running())
         return 0;
 
+    if ((selection & EC_POSSIBLE_SELECTIONS) == 0)
+        return 1; /* nothing to validate */
+
     ctx = BN_CTX_new_ex(ossl_ec_key_get_libctx(eck));
     if  (ctx == NULL)
         return 0;
 
-    if ((selection & EC_POSSIBLE_SELECTIONS) == 0)
-        return 1; /* nothing to validate */
-
     if ((selection & OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS) != 0)
         ok = ok && EC_GROUP_check(EC_KEY_get0_group(eck), ctx);