From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 4 Feb 2021 09:39:56 +0000 (+0100)
Subject: MINOR: dns: Don't set the check port during a server dns resolution
X-Git-Tag: v2.4-dev7~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=21ca3dfc3a64e6accdb91539960d9f2dac63cdbc;p=thirdparty%2Fhaproxy.git

MINOR: dns: Don't set the check port during a server dns resolution

When a server dns resolution is performed, there is no reason to set an
unconfigured check port with the server port. Because by default, if the
check port is not set, the server's one is used. Thus we can remove this
useless assignment. It is mandatory for next improvements.
---

diff --git a/src/dns.c b/src/dns.c
index 8c97df46b7..69045ce69f 100644
--- a/src/dns.c
+++ b/src/dns.c
@@ -712,9 +712,6 @@ static void dns_check_dns_response(struct dns_resolution *res)
 
 				srv->svc_port = item->port;
 				srv->flags   &= ~SRV_F_MAPPORTS;
-				if ((srv->check.state & CHK_ST_CONFIGURED) &&
-				    !(srv->flags & SRV_F_CHECKPORT))
-					srv->check.port = item->port;
 
 				if (!srv->dns_opts.ignore_weight) {
 					char weight[9];