From: Tom de Vries Date: Fri, 29 Mar 2024 06:47:30 +0000 (+0100) Subject: [gdb/testsuite] Add missing includes in gdb.trace/collection.c X-Git-Tag: gdb-15-branchpoint~566 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=221918140b0b4a52674491d7ab4487da02d063a7;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite] Add missing includes in gdb.trace/collection.c On fedora rawhide, with test-case gdb.trace/collection.exp, I get: ... gdb compile failed, collection.c: In function 'strings_test_func': collection.c:227:13: error: implicit declaration of function 'malloc' \ [-Wimplicit-function-declaration] 227 | longloc = malloc(500); | ^~~~~~ collection.c:1:1: note: \ include '' or provide a declaration of 'malloc' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:228:3: error: implicit declaration of function 'strcpy' \ [-Wimplicit-function-declaration] 228 | strcpy(longloc, ... ); | ^~~~~~ collection.c:1:1: note: include '' or provide a declaration of \ 'strcpy' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:230:8: error: implicit declaration of function 'strlen' \ [-Wimplicit-function-declaration] 230 | i += strlen (locstr); | ^~~~~~ collection.c:230:8: note: include '' or provide a declaration of \ 'strlen' ... Fix this by adding the missing includes. Tested on aarch64-linux. Approved-By: John Baldwin --- diff --git a/gdb/testsuite/gdb.trace/collection.c b/gdb/testsuite/gdb.trace/collection.c index efcc2e389da..8379b7d7eaf 100644 --- a/gdb/testsuite/gdb.trace/collection.c +++ b/gdb/testsuite/gdb.trace/collection.c @@ -19,6 +19,9 @@ * Test program for trace collection */ +#include +#include + /* * Typedefs */