From: Eric Blake <eblake@redhat.com>
Date: Mon, 4 Jul 2011 02:32:22 +0000 (+0800)
Subject: vmware: avoid null deref on failed lookup
X-Git-Tag: v0.9.3~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=222f6233b4f441b8e70194f21c574d03f16df3f8;p=thirdparty%2Flibvirt.git

vmware: avoid null deref on failed lookup

* src/vmware/vmware_driver.c (vmwareDomainReboot): Check error
  before dereferencing memory.
---

diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
index 5e2c4ba6b5..52582d6281 100644
--- a/src/vmware/vmware_driver.c
+++ b/src/vmware/vmware_driver.c
@@ -461,7 +461,6 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED)
     vmwareDriverLock(driver);
     vm = virDomainFindByUUID(&driver->domains, dom->uuid);
     vmwareDriverUnlock(driver);
-    vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath;
 
     if (!vm) {
         vmwareError(VIR_ERR_NO_DOMAIN, "%s",
@@ -469,6 +468,7 @@ vmwareDomainReboot(virDomainPtr dom, unsigned int flags ATTRIBUTE_UNUSED)
         goto cleanup;
     }
 
+    vmxPath = ((vmwareDomainPtr) vm->privateData)->vmxPath;
     vmwareSetSentinal(cmd, vmw_types[driver->type]);
     vmwareSetSentinal(cmd, vmxPath);