From: John Snow Date: Mon, 9 Aug 2021 09:01:00 +0000 (+0200) Subject: python: Reduce strictness of pylint's duplicate-code check X-Git-Tag: v6.2.0-rc0~121^2~54 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=22305c2a081b8b67e1181ebd821c076cc36fdcd2;p=thirdparty%2Fqemu.git python: Reduce strictness of pylint's duplicate-code check Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it doesn't trigger for functions with long, multi-line signatures. When we decide to upgrade to pylint 2.8.3 or greater, we will be able to use 'ignore-signatures = true' to the config instead. I'd prefer not to keep us on the very bleeding edge of pylint if I can help it -- 2.8.3 came out only three days ago at time of writing. See: https://github.com/PyCQA/pylint/pull/4474 Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: John Snow Reviewed-by: Max Reitz Message-Id: <20210809090114.64834-3-eesposit@redhat.com> Signed-off-by: Hanna Reitz --- diff --git a/python/setup.cfg b/python/setup.cfg index 14bab902883..83909c1c975 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -105,6 +105,11 @@ good-names=i, # Ignore imports when computing similarities. ignore-imports=yes +# Minimum lines number of a similarity. +# TODO: Remove after we opt in to Pylint 2.8.3. See commit msg. +min-similarity-lines=6 + + [isort] force_grid_wrap=4 force_sort_within_sections=True