From: Francesco Chemolli <5175948+kinkie@users.noreply.github.com>
Date: Sun, 1 Dec 2024 11:34:00 +0000 (+0000)
Subject: NoNewGlobals for Comm::AcceptLimiter::Instance_ (#1954)
X-Git-Tag: SQUID_7_0_1~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=224061c7f0c340d51bf3ef3414f4940ff26ba5ba;p=thirdparty%2Fsquid.git

NoNewGlobals for Comm::AcceptLimiter::Instance_ (#1954)

Inspired by Coverity. CID 1441988: Useless call (USELESS_CALL).
---

diff --git a/src/comm.cc b/src/comm.cc
index 24fe6ce462..c5f4751bc7 100644
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -1154,9 +1154,6 @@ comm_init(void)
 {
     assert(fd_table);
 
-    /* make sure the accept() socket FIFO delay queue exists */
-    Comm::AcceptLimiter::Instance();
-
     // make sure the IO pending callback table exists
     Comm::CallbackTableInit();
 
diff --git a/src/comm/AcceptLimiter.cc b/src/comm/AcceptLimiter.cc
index a303592b89..6df2bd2a05 100644
--- a/src/comm/AcceptLimiter.cc
+++ b/src/comm/AcceptLimiter.cc
@@ -13,12 +13,11 @@
 #include "fde.h"
 #include "globals.h"
 
-Comm::AcceptLimiter Comm::AcceptLimiter::Instance_;
-
 Comm::AcceptLimiter &
 Comm::AcceptLimiter::Instance()
 {
-    return Instance_;
+    static const auto Instance_ = new AcceptLimiter();
+    return *Instance_;
 }
 
 void
diff --git a/src/comm/AcceptLimiter.h b/src/comm/AcceptLimiter.h
index 6f18c9a8b1..e5e1435ccc 100644
--- a/src/comm/AcceptLimiter.h
+++ b/src/comm/AcceptLimiter.h
@@ -43,8 +43,6 @@ public:
     void kick();
 
 private:
-    static AcceptLimiter Instance_;
-
     /** FIFO queue */
     std::deque<TcpAcceptor::Pointer> deferred_;
 };