From: Pan Nengyuan Date: Sat, 7 Mar 2020 03:07:56 +0000 (+0800) Subject: core/qdev: fix memleak in qdev_get_gpio_out_connector() X-Git-Tag: v5.0.0-rc0~49^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2244f2335ea8f3b92cbecbb123dc392570b06e6c;p=thirdparty%2Fqemu.git core/qdev: fix memleak in qdev_get_gpio_out_connector() Fix a memory leak in qdev_get_gpio_out_connector(). Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Marc-André Lureau Message-Id: <20200307030756.5913-1-pannengyuan@huawei.com> Signed-off-by: Laurent Vivier --- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 3937d1eb1a5..85f062def72 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -557,7 +557,7 @@ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int n) { - char *propname = g_strdup_printf("%s[%d]", + g_autofree char *propname = g_strdup_printf("%s[%d]", name ? name : "unnamed-gpio-out", n); qemu_irq ret = (qemu_irq)object_property_get_link(OBJECT(dev), propname,