From: Tom Tromey Date: Fri, 5 Jul 2019 18:38:44 +0000 (-0600) Subject: Simplify tui_show_disassem X-Git-Tag: binutils-2_33~249 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=22c3f4909af125b457564db66e3cb3c56cb9abd3;p=thirdparty%2Fbinutils-gdb.git Simplify tui_show_disassem tui_show_disassem does not need to call tui_add_win_to_layout, because the callers that could change the layout have already ensured that it exists. gdb/ChangeLog 2019-08-13 Tom Tromey * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call tui_add_win_to_layout. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8e70be6ebdd..50128426f0c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-08-13 Tom Tromey + + * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call + tui_add_win_to_layout. + 2019-08-13 Tom Tromey * tui/tui-layout.h (tui_default_win_height): Don't declare. diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 80f8d47f0ac..a442a00019e 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -255,9 +255,10 @@ tui_show_disassem (struct gdbarch *gdbarch, CORE_ADDR start_addr) struct tui_win_info *win_with_focus = tui_win_with_focus (); struct tui_line_or_address val; + gdb_assert (TUI_DISASM_WIN != nullptr && TUI_DISASM_WIN->is_visible); + val.loa = LOA_ADDRESS; val.u.addr = start_addr; - tui_add_win_to_layout (DISASSEM_WIN); tui_update_source_window (TUI_DISASM_WIN, gdbarch, s, val, FALSE); /* If the focus was in the src win, put it in the asm win, if the