From: Hans Verkuil Date: Thu, 8 Oct 2020 11:59:12 +0000 (+0200) Subject: media: tvp7002: fix uninitialized variable warning X-Git-Tag: v5.10-rc1~175^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2311072d9905b1f810a3c0665362ee552f076c26;p=thirdparty%2Fkernel%2Flinux.git media: tvp7002: fix uninitialized variable warning tvp7002.c: In function 'tvp7002_g_register': tvp7002.c:691:11: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] 691 | reg->val = val; | ~~~~~~~~~^~~~~ Just return without setting 'reg' if tvp7002_read returns an error. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c index de313b1306daa..ada4ec5ef7828 100644 --- a/drivers/media/i2c/tvp7002.c +++ b/drivers/media/i2c/tvp7002.c @@ -688,9 +688,11 @@ static int tvp7002_g_register(struct v4l2_subdev *sd, int ret; ret = tvp7002_read(sd, reg->reg & 0xff, &val); + if (ret < 0) + return ret; reg->val = val; reg->size = 1; - return ret; + return 0; } /*