From: Eric Botcazou <ebotcazou@adacore.com>
Date: Fri, 1 Dec 2023 15:53:02 +0000 (+0100)
Subject: ada: Rework comment in Expand_Ctrl_Function_Call
X-Git-Tag: basepoints/gcc-15~3432
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=23508d3dc673de88af9a43d34d723863f1edd61d;p=thirdparty%2Fgcc.git

ada: Rework comment in Expand_Ctrl_Function_Call

This expands on the reason for properly guarding the transformation.

gcc/ada/

	* exp_ch6.adb (Expand_Ctrl_Function_Call): Rework last comment.
---

diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
index 195e34a34791..8e4c9035b224 100644
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -5477,7 +5477,12 @@ package body Exp_Ch6 is
 
       Set_Analyzed (N);
 
-      --  Apply the transformation, unless it was already applied manually
+      --  Apply the transformation unless it was already applied earlier. This
+      --  may happen because Remove_Side_Effects can be called during semantic
+      --  analysis, for example from Build_Actual_Subtype_Of_Component. It is
+      --  crucial to avoid creating a reference of reference here, because it
+      --  would not be subsequently recognized by the Is_Finalizable_Transient
+      --  and Requires_Cleanup_Actions predicates.
 
       if Nkind (Par) /= N_Reference then
          Remove_Side_Effects (N);