From: Jon Murphy <jon.murphy@ipfire.org>
Date: Fri, 2 Jun 2023 19:01:16 +0000 (-0500)
Subject: extrahd.cgi: Fix for Bug #12863
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=236e89ae87063bb1883875f76080d3f03c0351d5;p=people%2Fms%2Fipfire-2.x.git

extrahd.cgi: Fix for Bug #12863

-Fixes remove entries in 'extrahd' via the webinterface for extrahd.cgi file.

Suggested-by: Bernhard Bitsch <bbitsch@ipfire.org>
Signed-off-by: Jon Murphy <jon.murphy@ipfire.org>
Reviewed-by: Michael Tremer <michael.tremer@ipfire.org>
Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>
---

diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
index 36c0efc2ef..9dd3a0eeed 100644
--- a/html/cgi-bin/extrahd.cgi
+++ b/html/cgi-bin/extrahd.cgi
@@ -103,7 +103,7 @@ END
 }
 elsif ($extrahdsettings{'ACTION'} eq $Lang::tr{'delete'})
 {
-	if ( &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdsettings{'PATH'}")) {
+	if ( ! &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdsettings{'PATH'}")) {
 		open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
 		@tmp = <FILE>;
 		close FILE;