From: Antonio Quartulli Date: Mon, 20 Mar 2023 19:58:20 +0000 (+0100) Subject: dco-linux: remove M_ERRNO flag when printing netlink error message X-Git-Tag: v2.7_alpha1~508 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=23903fd579353c9892415a750f17a9832a79cced;p=thirdparty%2Fopenvpn.git dco-linux: remove M_ERRNO flag when printing netlink error message Netlink has its own error space and reports errors via the return value of its functions. For this reason remove the M_ERRNO flag when printing its errors. At the moment we get something like this: netlink reports error (-7): Invalid input data or parameter: Interrupted system call (errno=4) where the errno=4 (and its human readable representation) is a leftover from the previous recv() interrupted by a signal and it is totally unrelated to this netlink failure. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20230320195820.6675-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26452.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index e5cea3c71..47961849b 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -153,7 +153,7 @@ ovpn_nl_recvmsgs(dco_context_t *dco, const char *prefix) default: if (ret) { - msg(M_NONFATAL|M_ERRNO, "%s: netlink reports error (%d): %s", prefix, ret, nl_geterror(-ret)); + msg(M_NONFATAL, "%s: netlink reports error (%d): %s", prefix, ret, nl_geterror(-ret)); } break; }