From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Fri, 9 Aug 2024 14:15:56 +0000 (+0200)
Subject: memory: ti-aemif: don't needlessly iterate over child nodes
X-Git-Tag: v6.12-rc1~187^2~24^2~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=23a641d5c2bce4c723fff9118a5d865ee6b9d05a;p=thirdparty%2Fkernel%2Flinux.git

memory: ti-aemif: don't needlessly iterate over child nodes

When populating devices from a specific node, we don't need to call
of_platform_populate() for every child node manually - the routine
will already do it. We can call it directly from the platform device's
OF node. While at it: use the managed variant of of_platform_populate().

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20240809-ti-aemif-v1-3-27b1e5001390@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c
index fbe0786f5ac44..49e7cbe98fdb3 100644
--- a/drivers/memory/ti-aemif.c
+++ b/drivers/memory/ti-aemif.c
@@ -383,13 +383,9 @@ static int aemif_probe(struct platform_device *pdev)
 	 * child will be probed after the AEMIF timing parameters are set.
 	 */
 	if (np) {
-		for_each_available_child_of_node(np, child_np) {
-			ret = of_platform_populate(child_np, NULL, NULL, dev);
-			if (ret < 0) {
-				of_node_put(child_np);
-				return ret;
-			}
-		}
+		ret = devm_of_platform_populate(dev);
+		if (ret)
+			return ret;
 	}
 
 	return 0;