From: Thomas Munro <tmunro@postgresql.org>
Date: Wed, 23 Sep 2020 21:26:09 +0000 (+1200)
Subject: Fix missing fsync of SLRU directories.
X-Git-Tag: REL9_5_24~50
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=23d8b3577d0c247731addc188fe0479aa8f81c45;p=thirdparty%2Fpostgresql.git

Fix missing fsync of SLRU directories.

Harmonize behavior by moving reponsibility for fsyncing directories down
into slru.c.  In 10 and later, only the multixact directories were
missed (see commit 1b02be21), and in older branches all SLRUs were
missed.

Back-patch to all supported releases.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CA%2BhUKGLtsTUOScnNoSMZ-2ZLv%2BwGh01J6kAo_DM8mTRq1sKdSQ%40mail.gmail.com
---

diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
index 680a28f198d..b4d551fc33a 100644
--- a/src/backend/access/transam/slru.c
+++ b/src/backend/access/transam/slru.c
@@ -1133,6 +1133,10 @@ SimpleLruFlush(SlruCtl ctl, bool allow_redirtied)
 	}
 	if (!ok)
 		SlruReportIOError(ctl, pageno, InvalidTransactionId);
+
+	/* Ensure that directory entries for new files are on disk. */
+	if (ctl->do_fsync)
+		fsync_fname(ctl->Dir, true);
 }
 
 /*