From: Greg Kroah-Hartman Date: Fri, 24 May 2019 15:44:19 +0000 (+0200) Subject: 4.19-stable patches X-Git-Tag: v5.1.5~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=23ef42a93b2feaecaef4fd392371f6e21399b2d3;p=thirdparty%2Fkernel%2Fstable-queue.git 4.19-stable patches added patches: fbdev-sm712fb-fix-memory-frequency-by-avoiding-a-switch-case-fallthrough.patch --- diff --git a/queue-4.19/fbdev-sm712fb-fix-memory-frequency-by-avoiding-a-switch-case-fallthrough.patch b/queue-4.19/fbdev-sm712fb-fix-memory-frequency-by-avoiding-a-switch-case-fallthrough.patch new file mode 100644 index 00000000000..18840c65b6a --- /dev/null +++ b/queue-4.19/fbdev-sm712fb-fix-memory-frequency-by-avoiding-a-switch-case-fallthrough.patch @@ -0,0 +1,46 @@ +From 9dc20113988b9a75ea6b3abd68dc45e2d73ccdab Mon Sep 17 00:00:00 2001 +From: Yifeng Li +Date: Tue, 2 Apr 2019 17:14:10 +0200 +Subject: fbdev: sm712fb: fix memory frequency by avoiding a switch/case fallthrough + +From: Yifeng Li + +commit 9dc20113988b9a75ea6b3abd68dc45e2d73ccdab upstream. + +A fallthrough in switch/case was introduced in f627caf55b8e ("fbdev: +sm712fb: fix crashes and garbled display during DPMS modesetting"), +due to my copy-paste error, which would cause the memory clock frequency +for SM720 to be programmed to SM712. + +Since it only reprograms the clock to a different frequency, it's only +a benign issue without visible side-effect, so it also evaded Sudip +Mukherjee's code review and regression tests. scripts/checkpatch.pl +also failed to discover the issue, possibly due to nested switch +statements. + +This issue was found by Stephen Rothwell by building linux-next with +-Wimplicit-fallthrough. + +Reported-by: Stephen Rothwell +Fixes: f627caf55b8e ("fbdev: sm712fb: fix crashes and garbled display during DPMS modesetting") +Signed-off-by: Yifeng Li +Cc: Sudip Mukherjee +Cc: "Gustavo A. R. Silva" +Cc: Kees Cook +Signed-off-by: Bartlomiej Zolnierkiewicz +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/video/fbdev/sm712fb.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/drivers/video/fbdev/sm712fb.c ++++ b/drivers/video/fbdev/sm712fb.c +@@ -898,6 +898,7 @@ static int smtc_blank(int blank_mode, st + case 0x712: + smtc_seqw(0x6a, 0x16); + smtc_seqw(0x6b, 0x02); ++ break; + case 0x720: + smtc_seqw(0x6a, 0x0d); + smtc_seqw(0x6b, 0x02); diff --git a/queue-4.19/series b/queue-4.19/series index c46a187179a..43a74011526 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -112,3 +112,4 @@ revert-selftests-bpf-skip-verifier-tests-for-unsupported-program-types.patch bpf-relax-inode-permission-check-for-retrieving-bpf-program.patch bpf-add-map_lookup_elem_sys_only-for-lookups-from-syscall-side.patch bpf-lru-avoid-messing-with-eviction-heuristics-upon-syscall-lookup.patch +fbdev-sm712fb-fix-memory-frequency-by-avoiding-a-switch-case-fallthrough.patch