From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 27 Dec 2024 20:25:30 +0000 (-0800)
Subject: sign-compare: avoid comparing ptrdiff with an int/unsigned
X-Git-Tag: v2.49.0-rc0~104^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24027256aa9614a445563707a72af7ce5ff49b5b;p=thirdparty%2Fgit.git

sign-compare: avoid comparing ptrdiff with an int/unsigned

Instead, offset the base pointer with integer and compare it with
the other pointer.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/shallow.c b/shallow.c
index b8fcfbef0f..b54244ffa9 100644
--- a/shallow.c
+++ b/shallow.c
@@ -534,7 +534,7 @@ static uint32_t *paint_alloc(struct paint_info *info)
 	unsigned nr = DIV_ROUND_UP(info->nr_bits, 32);
 	unsigned size = nr * sizeof(uint32_t);
 	void *p;
-	if (!info->pool_count || size > info->end - info->free) {
+	if (!info->pool_count || info->end < info->free + size) {
 		if (size > POOL_SIZE)
 			BUG("pool size too small for %d in paint_alloc()",
 			    size);