From: Eric Wong <e@80x24.org>
Date: Tue, 29 Apr 2025 17:16:49 +0000 (+0000)
Subject: dskqxs: ignore all EV_DISABLE failures
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=240acec6d492b4d2b684bccb9442402f8b71917b;p=thirdparty%2Fpublic-inbox.git

dskqxs: ignore all EV_DISABLE failures

It's impossible to check for the same errors on non-registered
FDs with the poll(2) and select(2) backends while our epoll
backend has historically ignored failed EPOLL_CTL_DEL ops.  So
just ignore it for now since synchronous use of XhcMset in lei
can trigger the unnecessary EV_DISABLE.
---

diff --git a/lib/PublicInbox/DSKQXS.pm b/lib/PublicInbox/DSKQXS.pm
index dc6621e46..069472fc3 100644
--- a/lib/PublicInbox/DSKQXS.pm
+++ b/lib/PublicInbox/DSKQXS.pm
@@ -113,7 +113,7 @@ sub ep_del {
 	my ($self, $io, $ev) = @_;
 	my $kq = $_[0]->{kq} // return; # called in cleanup
 	my $fd = fileno($io);
-	$kq->EV_SET($fd, EVFILT_READ, EV_DISABLE);
+	eval { $kq->EV_SET($fd, EVFILT_READ, EV_DISABLE) };
 	eval { $kq->EV_SET($fd, EVFILT_WRITE, EV_DISABLE) };
 	0;
 }