From: zhanchengbin <zhanchengbin1@huawei.com>
Date: Mon, 10 Oct 2022 09:23:24 +0000 (+0800)
Subject: fsck: Processes may kill other processes.
X-Git-Tag: v2.39-rc1~488
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=240f2ea95724a2045afebef703f9a7e62326b603;p=thirdparty%2Futil-linux.git

fsck: Processes may kill other processes.

A error in disk-utils/fsck.c, if run the fsck -N command, processes
don't execute, just show what would be done. However, the pid whose
value is -1 is added to the instance_list list in the execute
function,if the kill_all function is called later, kill(-1, signum)
is executed, Signals are sent to all processes except the number one
process and itself. Other processes will be killed if they use the
default signal processing function.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
---

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index 505952c811..800d3ce08c 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -730,6 +730,8 @@ static int kill_all(int signum)
 	for (inst = instance_list; inst; inst = inst->next) {
 		if (inst->flags & FLAG_DONE)
 			continue;
+		if (inst->pid <= 0)
+			continue;
 		kill(inst->pid, signum);
 		n++;
 	}