From: Juan Quintela <quintela@redhat.com>
Date: Thu, 4 Mar 2010 09:00:31 +0000 (+0100)
Subject: slirp: check system() success
X-Git-Tag: v0.13.0-rc0~1146
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24ac07dec7f23c58dc48aa7754f872781b386d46;p=thirdparty%2Fqemu.git

slirp: check system() success

we shouldn't call W*() macros until we check that fork worked.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/net/slirp.c b/net/slirp.c
index 317cca7f63f..7f846ec6f9e 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s)
     if (s->smb_dir[0] != '\0') {
         snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir);
         ret = system(cmd);
-        if (!WIFEXITED(ret)) {
+        if (ret == -1 || !WIFEXITED(ret)) {
             qemu_error("'%s' failed.\n", cmd);
         } else if (WEXITSTATUS(ret)) {
             qemu_error("'%s' failed. Error code: %d\n",