From: Michael Paquier <michael@paquier.xyz>
Date: Tue, 27 Jul 2021 01:58:21 +0000 (+0900)
Subject: Simplify matching pattern check in TAP tests of pg_receivewal
X-Git-Tag: REL_15_BETA1~1806
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24ba1a87e4056ec34c8a685633a1a14fb89e5700;p=thirdparty%2Fpostgresql.git

Simplify matching pattern check in TAP tests of pg_receivewal

A check in the ZLIB portion of the test to match the name of a
non-compressed partial segment with a completed compressed segment was
using m//, while a simple equality check is enough.  This makes the test
a bit stricter without impacting its coverage.

Author: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20210726.174622.826565852378770261.horikyota.ntt@gmail.com
---

diff --git a/src/bin/pg_basebackup/t/020_pg_receivewal.pl b/src/bin/pg_basebackup/t/020_pg_receivewal.pl
index 47c4ecb073b..950083d21c8 100644
--- a/src/bin/pg_basebackup/t/020_pg_receivewal.pl
+++ b/src/bin/pg_basebackup/t/020_pg_receivewal.pl
@@ -111,7 +111,7 @@ SKIP:
 	# of the previous partial, now-completed WAL segment is updated, keeping
 	# its base number.
 	$partial_wals[0] =~ s/\.partial$/.gz/;
-	is($zlib_wals[0] =~ m/$partial_wals[0]/,
+	is($zlib_wals[0] eq $partial_wals[0],
 		1, "one partial WAL segment is now completed");
 	# Update the list of partial wals with the current one.
 	@partial_wals = @zlib_partial_wals;