From: William Lallemand <wlallemand@haproxy.com>
Date: Tue, 14 Jan 2020 16:58:18 +0000 (+0100)
Subject: BUG/MEDIUM: mworker: remain in mworker mode during reload
X-Git-Tag: v2.2-dev1~113
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24c928c8bd86f6899d39dd5cd04b3e50b4b993a8;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: mworker: remain in mworker mode during reload

If you reload an haproxy started in master-worker mode with
"master-worker" in the configuration, and no "-W" argument,
the new process lost the fact that is was in master-worker mode
resulting in weird behaviors.

The bigest problem is that if it is reloaded with an bad configuration,
the master will exits instead of remaining in waitpid mode.

This problem was discovered in bug #443.

Should be backported in every version using the master-worker mode.
(as far as 1.8)
---

diff --git a/src/haproxy.c b/src/haproxy.c
index 30c43c11ba..05268e1e7e 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -1496,6 +1496,10 @@ static void init(int argc, char **argv)
 	memcpy(localpeer, hostname, (sizeof(hostname) > sizeof(localpeer) ? sizeof(localpeer) : sizeof(hostname)) - 1);
 	setenv("HAPROXY_LOCALPEER", localpeer, 1);
 
+	/* we were in mworker mode, we should restart in mworker mode */
+	if (getenv("HAPROXY_MWORKER_REEXEC") != NULL)
+		global.mode |= MODE_MWORKER;
+
 	/*
 	 * Initialize the previously static variables.
 	 */