From: William Lallemand <wlallemand@haproxy.com>
Date: Fri, 2 May 2025 07:27:15 +0000 (+0200)
Subject: BUG/MINOR: acme: reinit the retries only at next request
X-Git-Tag: v3.2-dev14~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24fbd1f724675d9760a9a1fb4c7e6e6ab8990859;p=thirdparty%2Fhaproxy.git

BUG/MINOR: acme: reinit the retries only at next request

The retries were reinitialized incorrectly, it must be reinit only
when we didn't retry. So any valid response would reinit the retries
number.
---

diff --git a/src/acme.c b/src/acme.c
index 97885e5c6..139d2ad34 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -1927,7 +1927,6 @@ re:
 
 	/* this is called after initializing a request */
 	MT_LIST_UNLOCK_FULL(&ctx->el, tmp);
-	ctx->retries = ACME_RETRY;
 	ctx->http_state = http_st;
 	ctx->state = st;
 	task->expire = TICK_ETERNITY;
@@ -1936,6 +1935,7 @@ re:
 nextreq:
 	/* this is called when changing step in the state machine */
 	http_st = ACME_HTTP_REQ;
+	ctx->retries = ACME_RETRY; /* reinit the retries */
 	goto re; /* optimize by not leaving the task for the next httpreq to init */
 
 retry: