From: Phil Sutter <phil@nwl.cc>
Date: Wed, 30 Mar 2022 15:54:13 +0000 (+0200)
Subject: xlate-test: Fix for empty source line on failure
X-Git-Tag: v1.8.8~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=24fff5d7de02ac4dcd288565f1527028a797fad5;p=thirdparty%2Fiptables.git

xlate-test: Fix for empty source line on failure

The code overwrites 'line' before checking expected output. Save it in a
temporary variable.

Fixes: 62828a6aff231 ("tests: xlate-test: support multiline expectation")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/xlate-test.py b/xlate-test.py
index d78e8648..03bef7e2 100755
--- a/xlate-test.py
+++ b/xlate-test.py
@@ -42,6 +42,7 @@ def run_test(name, payload):
     line = payload.readline()
     while line:
         if line.startswith(keywords):
+            sourceline = line
             tests += 1
             process = Popen([ xtables_nft_multi ] + shlex.split(line), stdout=PIPE, stderr=PIPE)
             (output, error) = process.communicate()
@@ -58,7 +59,7 @@ def run_test(name, payload):
                     test_passed = False
                     failed += 1
                     result.append(name + ": " + red("Fail"))
-                    result.append(magenta("src: ") + line.rstrip(" \n"))
+                    result.append(magenta("src: ") + sourceline.rstrip(" \n"))
                     result.append(magenta("exp: ") + expected)
                     result.append(magenta("res: ") + translation + "\n")
                 else: