From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Date: Thu, 19 Sep 2024 04:46:41 +0000 (-0700)
Subject: scripts/checkpatch.pl: emit error when using assert(false)
X-Git-Tag: v9.2.0-rc0~72^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2540a551d395179f42844d29c866402329b89b7c;p=thirdparty%2Fqemu.git

scripts/checkpatch.pl: emit error when using assert(false)

This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org>
[thuth: Split long line to avoid checkpatch error]
Signed-off-by: Thomas Huth <thuth@redhat.com>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f905..1b21249c91e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,10 @@ sub process {
 		if ($line =~ /\b(g_)?assert\(0\)/) {
 			ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
 		}
+		if ($line =~ /\b(g_)?assert\(false\)/) {
+			ERROR("use g_assert_not_reached() instead of assert(false)\n" .
+			      $herecurr);
+		}
 		if ($line =~ /\bstrerrorname_np\(/) {
 			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
 		}