From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 24 Jun 2021 22:13:23 +0000 (+0000)
Subject: SSL_SESSION::master_key cannot be falsy (#848)
X-Git-Tag: SQUID_6_0_1~319
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=254f6fb678aee50588d5891d046850c1b2d5c060;p=thirdparty%2Fsquid.git

SSL_SESSION::master_key cannot be falsy (#848)

SSL_SESSION::master_key data member is an array. It cannot be falsy.

This fixes clang -Wpointer-bool-conversion.
---

diff --git a/compat/openssl.h b/compat/openssl.h
index a3b2c1b5de..ccfcf78df6 100644
--- a/compat/openssl.h
+++ b/compat/openssl.h
@@ -175,7 +175,7 @@ extern "C" {
     inline size_t
     SSL_SESSION_get_master_key(const SSL_SESSION *session, unsigned char *outStart, size_t outSizeMax)
     {
-        if (!session || !session->master_key || session->master_key_length <= 0)
+        if (!session || session->master_key_length <= 0)
             return 0;
 
         const auto sourceSize = static_cast<size_t>(session->master_key_length);