From: Sergey Organov <sorganov@gmail.com>
Date: Mon, 21 Dec 2020 15:19:50 +0000 (+0300)
Subject: diff-merges: make -m/-c/--cc explicitly mutually exclusive
X-Git-Tag: v2.31.0-rc0~84^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=255a4dacc59f4f4f62cc61743f40a078b4b38647;p=thirdparty%2Fgit.git

diff-merges: make -m/-c/--cc explicitly mutually exclusive

-c/--cc got precedence over -m only because of external logic where
corresponding flags are checked before that for -m. This is too
error-prone, so add code that explicitly makes these 3 options
mutually exclusive, so that the last option specified on the
command-line gets precedence.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/diff-merges.c b/diff-merges.c
index b8fd92adcf..e3c0190ebd 100644
--- a/diff-merges.c
+++ b/diff-merges.c
@@ -8,6 +8,7 @@ static void suppress(struct rev_info *revs)
 	revs->first_parent_merges = 0;
 	revs->combine_merges = 0;
 	revs->dense_combined_merges = 0;
+	revs->combined_all_paths = 0;
 }
 
 static void set_separate(struct rev_info *revs)
@@ -29,12 +30,14 @@ static void set_m(struct rev_info *revs)
 
 static void set_combined(struct rev_info *revs)
 {
+	suppress(revs);
 	revs->combine_merges = 1;
 	revs->dense_combined_merges = 0;
 }
 
 static void set_dense_combined(struct rev_info *revs)
 {
+	suppress(revs);
 	revs->combine_merges = 1;
 	revs->dense_combined_merges = 1;
 }