From: Amos Jeffries <squid3@treenet.co.nz>
Date: Wed, 8 Feb 2017 17:57:26 +0000 (+1300)
Subject: Fix uninitialized variable in libadaptation
X-Git-Tag: M-staged-PR71~278
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=25660541d392ebd334b6d34c23f0f015d4362491;p=thirdparty%2Fsquid.git

Fix uninitialized variable in libadaptation

The grokBool() parse method does not alter the bool parameter on invalid
inputs. This results in encrypt local variabel bein gused uninitialized.
---

diff --git a/src/adaptation/ServiceConfig.cc b/src/adaptation/ServiceConfig.cc
index ad7f5409c3..1d4697bc84 100644
--- a/src/adaptation/ServiceConfig.cc
+++ b/src/adaptation/ServiceConfig.cc
@@ -139,7 +139,7 @@ Adaptation::ServiceConfig::parse()
             grokked = grokOnOverload(onOverload, value);
             onOverloadSet = true;
         } else if (strcmp(name, "connection-encryption") == 0) {
-            bool encrypt;
+            bool encrypt = false;
             grokked = grokBool(encrypt, name, value);
             connectionEncryption.configure(encrypt);
         } else if (strncmp(name, "ssl", 3) == 0 || strncmp(name, "tls-", 4) == 0) {