From: Colin Ian King <colin.i.king@gmail.com>
Date: Tue, 19 Dec 2023 14:13:04 +0000 (+0000)
Subject: x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()
X-Git-Tag: v6.8-rc1~197^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=257ca14f4d780e27a0605fd68053d2cc3178a232;p=thirdparty%2Fkernel%2Flinux.git

x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()

The 'delta' variable is zero-initialized, but never
read before the real initialization happens.

The assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231219141304.367200-1-colin.i.king@gmail.com
---

diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index 1c8541ae3b3ac..c23f3b9c84fe9 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -49,7 +49,7 @@ int strcmp(const char *str1, const char *str2)
 {
 	const unsigned char *s1 = (const unsigned char *)str1;
 	const unsigned char *s2 = (const unsigned char *)str2;
-	int delta = 0;
+	int delta;
 
 	while (*s1 || *s2) {
 		delta = *s1 - *s2;