From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 29 May 2025 23:31:24 +0000 (+1200)
Subject: samba_dnsupdate: slightly clarify handling of args
X-Git-Tag: tevent-0.17.0~47
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2594a0c57f43a4b0b16ab072833f8e0f0492b522;p=thirdparty%2Fsamba.git

samba_dnsupdate: slightly clarify handling of args

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13613

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>
---

diff --git a/source4/scripting/bin/samba_dnsupdate b/source4/scripting/bin/samba_dnsupdate
index 6d9d5bc3dee..ec8aed6edbe 100755
--- a/source4/scripting/bin/samba_dnsupdate
+++ b/source4/scripting/bin/samba_dnsupdate
@@ -589,10 +589,11 @@ def call_samba_tool(d, op="add", zone=None):
     global error_count
     try:
         cmd = cmd_dns()
+        full_args = ["dns", op, "--use-kerberos", "off", "-P"] + args
         if opts.verbose:
-            print(f'Calling samba-tool dns {op} --use-kerberos off -P {args}')
-        command, args = cmd._resolve("dns", op, "--use-kerberos", "off", "-P", *args)
-        ret = command._run(*args)
+            print(f'Calling samba-tool {" ".join(full_args)}')
+        command, resolved_args = cmd._resolve(*full_args)
+        ret = command._run(*resolved_args)
         if ret == -1:
             if opts.fail_immediately:
                 sys.exit(1)