From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Tue, 6 Aug 2024 03:38:57 +0000 (+1200)
Subject: drs_utils: Make loop exit condition explicit
X-Git-Tag: tevent-0.17.0~140
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=25c4ee2337cfc0c5ccf72cb7e47ad3f190b48df5;p=thirdparty%2Fsamba.git

drs_utils: Make loop exit condition explicit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15852

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/drs_utils.py b/python/samba/drs_utils.py
index 6142349be89..ab2d37e133c 100644
--- a/python/samba/drs_utils.py
+++ b/python/samba/drs_utils.py
@@ -231,10 +231,7 @@ class drs_Replicate(object):
 
         object_to_check = ctr.first_object
 
-        while True:
-            if object_to_check is None:
-                break
-
+        while object_to_check is not None:
             self.guids_seen.add(str(object_to_check.object.identifier.guid))
 
             if object_to_check.parent_object_guid is not None \