From: Volker Lendecke <vl@samba.org>
Date: Mon, 30 Dec 2024 11:55:15 +0000 (+0100)
Subject: libsmb: Remove a pointless if-statement
X-Git-Tag: tdb-1.4.13~120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=25dccd3a6e6b3fe72faa15b314e426e17a29492a;p=thirdparty%2Fsamba.git

libsmb: Remove a pointless if-statement

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index c7da7a1b14c..c079f84049e 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -2364,9 +2364,8 @@ struct tevent_req *cli_unlink_send(TALLOC_CTX *mem_ctx,
 		 * Don't allow attributes greater than
 		 * 16-bits for a 16-bit protocol value.
 		 */
-		if (tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER)) {
-			return tevent_req_post(req, ev);
-		}
+		tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
+		return tevent_req_post(req, ev);
 	}
 
 	SSVAL(state->vwv+0, 0, mayhave_attrs);