From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 13 Feb 2023 10:37:26 +0000 (+0100)
Subject: BUG/MEDIUM: spoe: Don't set the default traget for the SPOE agent frontend
X-Git-Tag: v2.8-dev4~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=25e36bfc228e8398171551f8c12fec29dcad0eae;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: spoe: Don't set the default traget for the SPOE agent frontend

The commit d5983cef8 ("MINOR: listener: remove the useless ->default_target
field") revealed a bug in the SPOE. No default-target must be defined for
the SPOE agent frontend. SPOE applets are used on the frontend side and a
TCP connection is established on the backend side.

Because of this bug, since the commit above, the stream target is set to the
SPOE applet instead of the backend connection, leading to a spinning loop on
the applet when it is released because are unable to close the backend side.

This patch should fix the issue #2040. It only affects the 2.8-DEV but to
avoid any future bug, it should be backported to all stable versions.
---

diff --git a/src/flt_spoe.c b/src/flt_spoe.c
index 3e4fe9735d..1f6b3a9f38 100644
--- a/src/flt_spoe.c
+++ b/src/flt_spoe.c
@@ -3053,7 +3053,6 @@ spoe_init(struct proxy *px, struct flt_conf *fconf)
         conf->agent_fe.accept = frontend_accept;
         conf->agent_fe.srv = NULL;
         conf->agent_fe.timeout.client = TICK_ETERNITY;
-	conf->agent_fe.default_target = &spoe_applet.obj_type;
 	conf->agent_fe.fe_req_ana = AN_REQ_SWITCHING_RULES;
 
 	if (!sighandler_registered) {